remove explicit SIMD reads and writes#303
Merged
folkertdev merged 2 commits intomainfrom Feb 25, 2025
Merged
Conversation
folkertdev
commented
Feb 25, 2025
Comment on lines
376
to
+378
| #[cfg(target_arch = "x86_64")] | ||
| if crate::cpu_features::is_enabled_avx512() { | ||
| helper!(Writer::copy_match_help::<__m512i>); | ||
| helper!(Writer::copy_match_help::<64>); |
Member
Author
There was a problem hiding this comment.
given our changes to where the target feature is applied, this will not test a simd read/write any more. But those should be semantically equivalent to an array of the corresponding size.
Codecov ReportAttention: Patch coverage is
|
bjorn3
approved these changes
Feb 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using standard
ptr::{read_unaligned, write_unaligned}on an[u8; N]generates the same code. That also means we can just pass the optimal read/write width as a const generic, which is much clearer.I think we can then also replace the
FEATURESconst generic with the preferred width, but I'll do that separately later.